-
Notifications
You must be signed in to change notification settings - Fork 745
Conversation
Hi @jneiva08, thanks for contributing, A few comments I have during my review:
Cheers, |
It is the only datasheet can be found. |
Hi @jneiva08
Me too.
Good point, that's good to keep library consistent so USB_DM accepted.
Right. I do not know what is the Kicad strategy about that, if you look at several symbol in the lib, you can find Passive, Bidirectionnal, Input and Output antennas. According to me Passive is only for NC pins. @antoniovazquezblanco what is your advice ? Cheers, PS : once decision is made or I you have time right know, @jneiva08 can you fix branch conflict so it will be ready to be merged ? Thanks. |
Fixed merge conflicts caused by other PRs merge.
We need help from one of the more experienced librarians here. @poeschlr, @evanshultz ? Thanks! |
This answer of evanshultz from other gsm modem PR can help? |
NC (not connected) pins should not have type passive but type not connected. I think antenna interface pins can be seen as input, output or even bidirectional. (depending on if your part is a receiver, transmitter or both.) The antenna it self however would be passive i think. Unless it is an active antenna. Edit: added a bit of clarification |
@jneiva08 I think the reason is not valid, we do not only use passive components on the ANT pins. Sometimes there are some amplifiers, RF switches, etc etc and of course there are active antennas. I prefer the response of @poeschlr . Typically GPS ANT is input (can eb discussed because it also power the antenna itself throw the RF line), 433MHz transmitter ANT is output, GSM / LPWAN etc etc are Bidirectional. Some devices can transmit lots of power on output ANT. @poeschlr which good use of Passive pin ? If you have an example ? Cheers, |
I'm guessing the other reason to be passive, is because you normally need to add a matching impedance circuit, when you are making ERC validation it do now give a error/warning. |
@myfreescalewebpage @jneiva08 |
@poeschlr since there is no clear KLC rules about antennas, I suggest @jneiva08 can keep its proposition to set it as Passive. When there is no guideline, submitter is the responsible of the commit, so he should keep the last word. Is it okay for you ? In any case this can be easily modified later if KLC are created on this subject. |
We are working on a better way to give users guidance regarding pin types: KiCad/kicad-website#342 |
Any librarian, this PR is only blocked because of ANT pin type question. What should we do ? |
@poeschlr your position maybe ? |
Looks good, thanks |
thanks for all your time |
The symbol was created from symbol SIM800C and footprint is the same.
Datasheet: https://simcom.ee/documents/SIM7020/SIM7020%20Hardware%20Design_V1.01.pdf
Symbol:
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items: